Finalizer fix #951
Merged
Finalizer fix #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropped outdated sdk build dependencies
Shazwazza
reviewed
Jun 25, 2024
src/Lucene.Net/Lucene.Net.csproj
Outdated
| <InternalsVisibleTo Include="Lucene.Net.Tests.TestFramework" /> | ||
| <InternalsVisibleTo Include="Lucene.Net.Tests.TestFramework.DependencyInjection" /> | ||
| </ItemGroup> | ||
| <Import Project="$(SolutionDir).build/nuget.props" /> |
There was a problem hiding this comment.
IMO formatting should be done in a separate PR. But that said, we should have correct indentation settings for more file types in .editorconfig and default settings for unspecified files. 2 spaces for XML/JSON type files seems to be the standard.
NightOwl888
requested changes
Aug 12, 2024
src/dotnet/Lucene.Net.Tests.CodeAnalysis/Lucene.Net.Tests.CodeAnalysis.csproj
Outdated
Show resolved
Hide resolved
…CodeAnalysis to publish tests for net8.0
NightOwl888
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Fixes #950
Description
Dropped the finalizer in IndexReader